Move EZSP send lock from EZSP to individual protocol handlers
#649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmulcahey
reviewed
Sep 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #649 +/- ##
=======================================
Coverage 99.13% 99.14%
=======================================
Files 50 50
Lines 3486 3494 +8
=======================================
+ Hits 3456 3464 +8
Misses 30 30 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently moved a lot of code into individual EZSP protocol handlers. This introduced a "hole" where protocol handlers could run multiple commands at once within a single semaphore.
This PR moves the semaphore into the protocol handlers, closing this hole. I've also adjusted protocol timeouts to better handle TCP failures, making communication with TCP coordinators a bit more resilient. I think after this PR we may be able to immediately disconnect on watchdog failure as opposed to allowing up to five to fail.
CC @tube0013